Skip to content

Added support for Arduino CLI 1.0.0 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Added support for Arduino CLI 1.0.0 #189

merged 3 commits into from
Jun 14, 2024

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jun 14, 2024

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?
Applied changes to support Arduino CLI 1.0.0

What is the current behavior?
The language server crashes, see #188 for details.

What is the new behavior?
The LS works normally.

Other information:
Supersedes #188
I'm starting this PR as a draft because I can't test it right now.

@cmaglie cmaglie self-assigned this Jun 14, 2024
@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 14, 2024
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested also on neovim v0.9.5 it works.

Let's remember to mention in the release changelog that this will be a breaking change, that will require the arduino-cli 1.0.0

@cmaglie cmaglie marked this pull request as ready for review June 14, 2024 11:10
@cmaglie cmaglie merged commit c1dbee2 into main Jun 14, 2024
17 checks passed
@cmaglie cmaglie deleted the support-cli-1.0 branch June 14, 2024 11:11
@cmaglie
Copy link
Member Author

cmaglie commented Jun 14, 2024

Thanks for testing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants